[mlpack-git] [mlpack/mlpack] Use move semantics to set a given reference tree in NeighborSearch class. (#743)

[Ryan Curtin]

I agree completely except for one point (below). I think GCC provides some symbols to mark methods deprecated, but I am not sure how portable they are. I don't currently have the ability to look into that, but I will when I have a chance unless you beat me to it. :)

Removing the old overloads would force a major version bump, and I'd prefer to be somewhat conservative with major version bumps. I am currently working on generic bindings to other languages, which would be a good reason for a major version bump (the completion of the ANN code would be another good reason).  So I think that either (or both) of those things can be done probably by the end of the year, and at that time we can remove all our collected reversed compatibility code and call it mlpack 3.0.0.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/743#issuecomment-239552765
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160812/01bb6ad6/attachment.html>