[mlpack-git] [mlpack/mlpack] CNE algorithm (#753)

[Marcus Edel]

> +  // Neurons.
> +  std::vector<NeuronGene> aNeuronGenes;
> +
> +  // Links.
> +  std::vector<LinkGene> aLinkGenes;
> +
> +  // Default constructor.
> +  Genome() {
> +    aId = -1;
> +    aNumInput = 0;
> +    aNumOutput = 0;
> +    aFitness = DBL_MAX;
> +  }
> +  
> +  // Parametric constructor.
> +  Genome(int id,

Some style issue here, we should:

- To be consistent with the rest of the codebase use the same naming conventions for the parameter and function names e.g. numInput instead of aNumInput. For more informations take a look at: https://github.com/mlpack/mlpack/wiki/DesignGuidelines#naming-conventions. Also, we tend to be very picky about coding standards and conventions, so if you find inconsistencies in existing code or things that are unclear and should be clarified, please feel free to point them out.

- We use doxygen to generate code documentation, so it would be great if you could adapt the style accordingly e.g.

```
/*
 * Construct the Genome object with the given parameters.
 *
 * @param id Genome identifier.
 * @param neuronGenes List of genes to construct the genome.
 * @param linkGenes List of links to construct the genome.
 * @param numInput Number of input genes.
 * @param numOutput Number of output genes.
 * @param fitness Initial fitness.
 */
Genome(int id,
       const std::vector<NeuronGene>& neuronGenes,
       const std::vector<LinkGene>& linkGenes,
       int numInput,
       int numOutput,
       double fitness):
```

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/753/files/10b99ab5c6e8d2836d231fa60a898cc03f7d9192#r73801977
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160807/744b369d/attachment.html>