[mlpack-git] [mlpack/mlpack] Descriptive Statistics command-line program (#742)
Tham
notifications at github.com
Sat Aug 6 23:23:17 EDT 2016
> + * @param rowStd Standard Deviation of the given vector.
> + * @param rowMean Mean of the given vector.
> + * @return Kurtosis of the given vector.
> + */
> +double Kurtosis(const arma::rowvec& input,
> + const double& fStd,
> + const double& fMean,
> + const bool population)
> +{
> + double kurtosis = 0;
> + const double M4 = SumNthPowerDeviations(input, fMean, 4);
> + const double n = input.n_elem;
> + if (population)
> + {
> + // Calculate Population Excess Kurtosis
> + double M2 = SumNthPowerDeviations(input, fMean, 2);
I think this is a good candidate of const too, as other variables in this function.
Sorry of being picky on const correctness.
After this is fixed, I think the codes are ready to merge
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/742/files/a5c996d43552de0b38a8ab4abca0b0739348e600#r73795163
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160806/8f48267b/attachment.html>
More information about the mlpack-git
mailing list