[mlpack-git] [mlpack/mlpack] Major changes to solve issue: #275. (#624)
notifications at github.com
Sat Apr 16 17:47:20 EDT 2016
The earlier code used to maintain a used set at the end of the indices and dataset array. In this commit I have kept the used set at the starting of the overall arrays. Also, since we are rearranging the data there is no use to keep the indices array. Also, the maintaining the used set at the start removes the need of using SortPointSet and MoveUsedSet function.
The Descendant function code has not been changed as well because the current code is buggy. Once that is done we can update the Descendant function.
Some part of the code has been commented and has been kept only to keep track of what has been changed. Those will be removed in further commits.
The reason for opening this PR is to clarify certain doubts and get review on the changes. Some of the doubts are as follows:
1. I am assuming that in the MoveToUsedSet function, we are trying to remove the datapoints which were in the nearSet and farSet of parent node but now has been moved to nearSet of the child node.
2. After the MoveToUsedSet function, the nearSet size changes to whatever elements of the nearSet that did not go to the child node's nearSet? Same for farset.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* Major changes to solve issue: #275. The code is still buggy and fails the unit tests
-- File Changes --
M src/mlpack/core/tree/cover_tree/cover_tree.hpp (48)
M src/mlpack/core/tree/cover_tree/cover_tree_impl.hpp (413)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the mlpack-git