[mlpack-git] [mlpack/mlpack] add train test split (#523)

stereomatchingkiss notifications at github.com
Wed Apr 13 13:01:34 EDT 2016

>Hmm, do you think that we should modify prereqs.hpp or something to define ARMA_USE_CXX11 when using Visual Studio 2015?

I think this is a good idea if everything still compile correctly

> Also maybe I am missing it but I don't see where std::move() is used, so maybe the comment is no longer necessary?

I do not use std::move to move them explicitly because this may generate less effective binary, compiler will try to do RVO if they could, if they could not, they would move the variable back, compiler is smart enough to find out they are local variable only needed by that function. 

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160413/eaf866b3/attachment.html>

More information about the mlpack-git mailing list