[mlpack-git] [mlpack/mlpack] add train test split (#523)

Ryan Curtin notifications at github.com
Tue Apr 12 16:20:19 EDT 2016


This looks good to me, but with the simpler API that does not accept cubes, do you think it is worth having a class for this, or would it be more reasonable to just have a function `TrainTestSplit()` which takes the data and the percentage for the test set?  I think that since `TrainTestSplit` only holds one member it would be easier to just make it a standalone function.  You could also add the overload that returns the `std::tuple<...>` too.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/523#issuecomment-209087043
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160412/06f508fb/attachment.html>


More information about the mlpack-git mailing list