[mlpack-git] [mlpack/mlpack] SGD performing optimization on same order of visitation at each rotation (#608)

[Ozair Shafiq]

In the main loop inside SGD::Optimize function,

At the beginning of a rotation on training Samples and if shuffle is enabled, we call arma::shuffle on visitationOrder vector to randomize the order in which the SGD will revisit the samples next time.

Since, arma::shuffle relies on a random number generator, whenever it is called, the armadillo library does not seem to reset/change the seed value for the rng, hence, I think it would be a good idea to reset the seed value before calling arma::shuffle on visitationOrder at line 83 by calling arma::arma_rng::set_seed_random() or another appropriate function.

Regards.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/608
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160409/8b6b1fa1/attachment-0001.html>