[mlpack-git] [mlpack] implement command line programs of softmaxRegression (#466)

stereomatchingkiss notifications at github.com
Thu Oct 29 23:20:19 EDT 2015

I have a question and two suggestions

The suggestion is could we make Prediction as const member function?Because it never changed any data member. 

Another suggestion is about performance, maybe cache the probabilities and hypothesis can speed up the process, especially when you need to use the same model to predict same dimension inputs data(this one need test, maybe it is not worth to do this kind of optimization). 

The question why the type of predictions is arma::vec?Since the labels are arma::Row<size_t>, I think the type of predictions should be arma::Row<size_t> too.

Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20151029/868a6984/attachment.html>

More information about the mlpack-git mailing list