[mlpack-git] [mlpack] Fix drop out layer (#463)

[stereomatchingkiss]

Sorry for my misunderstanding, I should open an issue before I treat it as a bug next time.

>So instead of using the constructor list or the else case of the forward pass, we could set the ratio at the beginning of the forward pass

Do you mean you want to set the ration when you call the Forward function?

    template<typename eT>
    void Forward(const arma::Mat<eT>& input, arma::Mat<eT>& output)
    {
      ratio = 0.5;
      //......
    }

But how could the user setup the ration under this case?

> One problem I see with the solution is that a change of the probability of setting a value to zero (ratio) has no effect

What about do the value checking when construct the dropout layer(at runtime)?
Or write down the preconditions on the comments if you do not want to do any runtime check(ask the users do not set ratio as 1.0 or 0.0)
Maybe there are better solutions there, but these are what I could come up with now.



---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/463#issuecomment-150010306
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20151021/276d5ee1/attachment.html>