[mlpack-git] [mlpack] fix constructor bug(oivs_init.hpp) (#462)

stereomatchingkiss notifications at github.com
Sun Oct 18 15:19:42 EDT 2015

>It's only needed in the constructor

epsilon is my mistake, I did not check the codes carefully.The original codes try to initialize "non-existent epsilon", so the compilation can not pass

>I avoided the initialization list in favor of readability

In this case, you have to declare b as non-const, because const data member must be initialize through the initialization list, else the compilation will fail.I am favor readability too:), maintainability 
is very important for long term development, In my humble opinion, codes quality of mlpack are quite well. 

>but maybe it doesn't make a huge difference

I think this is based on the taste of the programmers, if the initialization process is too complex, we could hide it in data member.

By the way, is it ok to change the parameters of Train to const(as the channel logs of 18/20/2015 suggest)?Thanks

Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20151018/0056bf5a/attachment.html>

More information about the mlpack-git mailing list