[mlpack-git] [mlpack] MaxVarianceNewCluster wrong distance to cluster mean (#469)
mikemodanoxxx
notifications at github.com
Wed Nov 11 08:10:37 EST 2015
Hi there,
I think the MaxVarianceNewCluster template has an error in the computation of the distance between the mean of the maximum variance cluster and a data point (lines 73-74):
double distance = arma::as_scalar(
arma::var(data.col(i) - centroids.col(maxVarCluster)));
The distance here is the variance of the difference vectors and not the distance between the vectors. I think it should be
double distance = metric::SquaredEuclideanDistance::Evaluate(
data.col(i), centroids.col(maxVarCluster));
instead.
---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/469
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20151111/a1025b69/attachment.html>
More information about the mlpack-git
mailing list