[mlpack-git] [mlpack] LoadSave Unit test fails Windows x64 (#468)

Ryan Curtin notifications at github.com
Tue Nov 10 19:59:02 EST 2015


But `read(buffer, length)` should fill the buffer with up to `length` characters, terminated with a `\0` (like typical C strings).  Is it instead reading the CR (ASCII value 13) into the buffer?  The rule that causes `guess_file_type()` to return `arma_binary` is below:

```
      // the range checking can be made more elaborate
      if( ((val_i <= 8) || (val_i >= 123)) || ((val_j <= 8) || (val_j >= 123)) )
        {
        has_binary = true;
        break;
        }
```

It sounds like maybe Conrad's comment applies here---we might simply need to make the rules more complex for Windows systems.

I don't have a Windows environment currently set up, so if you can help debug and test this, we can throw together a patch and send it upstream.

---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/468#issuecomment-155618186
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20151110/0e9bab02/attachment.html>


More information about the mlpack-git mailing list