[mlpack-git] master: When BinarySpaceTree was refactored, its traits were not. And thus the traits didn't work unless you were using the default SplitType. (f7c45b2)

gitdub at big.cc.gt.atl.ga.us gitdub at big.cc.gt.atl.ga.us
Fri May 8 12:03:29 EDT 2015


Repository : https://github.com/mlpack/mlpack

On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/dde839eaf3d49261add6b660e6fefcb22e9a163a...f7c45b202a6265cc34f46f0ccc70c21cf4b51110

>---------------------------------------------------------------

commit f7c45b202a6265cc34f46f0ccc70c21cf4b51110
Author: Ryan Curtin <ryan at ratml.org>
Date:   Fri May 8 12:03:02 2015 -0400

    When BinarySpaceTree was refactored, its traits were not.
    And thus the traits didn't work unless you were using the default SplitType.


>---------------------------------------------------------------

f7c45b202a6265cc34f46f0ccc70c21cf4b51110
 src/mlpack/core/tree/binary_space_tree/traits.hpp | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/mlpack/core/tree/binary_space_tree/traits.hpp b/src/mlpack/core/tree/binary_space_tree/traits.hpp
index 78aeba9..9d7dcf3 100644
--- a/src/mlpack/core/tree/binary_space_tree/traits.hpp
+++ b/src/mlpack/core/tree/binary_space_tree/traits.hpp
@@ -20,8 +20,9 @@ namespace tree {
  */
 template<typename BoundType,
          typename StatisticType,
-         typename MatType>
-class TreeTraits<BinarySpaceTree<BoundType, StatisticType, MatType> >
+         typename MatType,
+         typename SplitType>
+class TreeTraits<BinarySpaceTree<BoundType, StatisticType, MatType, SplitType>>
 {
  public:
   /**
@@ -47,7 +48,7 @@ class TreeTraits<BinarySpaceTree<BoundType, StatisticType, MatType> >
   static const bool RearrangesDataset = true;
 };
 
-}; // namespace tree
-}; // namespace mlpack
+} // namespace tree
+} // namespace mlpack
 
 #endif



More information about the mlpack-git mailing list