[mlpack-git] master: Don't include inside the mlpack namespace. A downstream user may try to re-include execinfo and get very confused when it silently fails. (bff92b7)

gitdub at big.cc.gt.atl.ga.us gitdub at big.cc.gt.atl.ga.us
Tue Mar 24 18:38:46 EDT 2015


Repository : https://github.com/mlpack/mlpack

On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/98fd81bd8477869fd45396404fdf5b2c3b32d83b...cbccdc78493a4db6cf6ebbf6442674bab8d9c22c

>---------------------------------------------------------------

commit bff92b7fcb2a834625e68eb01ed5c12bfbcbb331
Author: Ryan Curtin <ryan at ratml.org>
Date:   Tue Mar 24 18:26:19 2015 -0400

    Don't include inside the mlpack namespace.
    A downstream user may try to re-include execinfo and get very confused when it silently fails.


>---------------------------------------------------------------

bff92b7fcb2a834625e68eb01ed5c12bfbcbb331
 CMake/backtrace.h.in | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/CMake/backtrace.h.in b/CMake/backtrace.h.in
index c26f0c6..a83883a 100644
--- a/CMake/backtrace.h.in
+++ b/CMake/backtrace.h.in
@@ -1,13 +1,15 @@
+/**
+ * @file backtrace.hpp
+ *
+ * Configuration file that includes backtrace headers (if they exist on this
+ * system), auto-generated by CMake.
+ */
 #ifndef __MLPACK_CORE_UTIL_BACKTRACE_HPP
 #define __MLPACK_CORE_UTIL_BACKTRACE_HPP
 
-namespace mlpack {
-
 #cmakedefine01 Backtrace_FOUND
 #if Backtrace_FOUND
   #include <@Backtrace_HEADER@>
 #endif
 
-}; //namespace mlpack
-
 #endif



More information about the mlpack-git mailing list