[mlpack-git] [mlpack] Avoid inclusion of windows.h in timers.hpp or other mlpack headers (#425)

[Ryan Curtin]

This ticket comes out of #422.

Right now, on Windows, the header `<windows.h>` is included inside of `src/mlpack/core/util/timers.hpp` for the use of the `timeval` struct.  Because of the huge overhead that `windows.h` incurs when it is included, this can slow down compilation a fair amount (which is already slow because we are using complex template functionality of C++).

We can reduce this overhead significantly by refactoring `timers.hpp` and `timers.cpp` such that the `timeval` struct is not necessary in `timers.hpp` and instead used entirely within `timers.cpp`.  This should be a relatively easy refactoring job for someone who would like to make a first contribution to the library.

Thanks to theSundayProgrammer for pointing this issue out.

---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/425
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20150320/2bdbe5de/attachment-0001.html>