[mlpack-git] [mlpack] Error Compiling Triangular_kernel.hpp on Windows (#422)

[Ryan Curtin]

Ah, okay, now I understand better. The first patch was written on a plane waiting to take off so I'm not too surprised it didn't work perfectly. :)

I've taken a closer look at the situation and committed 8bd3f96. This removes the undef'ing of min/max entirely and sets `NOMINMAX` safely before including `windows.h`, like you suggested. Can you try it and see if that fixes the issue? Thanks for testing the previous patch, also.

I don't see a quick way to move the inclusion of the system-dependent headers into timers.cpp, since the Timers class exposes some methods and has some members that require a definition of the `timeval` type. If you'd like to refactor and submit a pull request, I'm happy to go that direction, but I'm also happy enough to leave it as-is.

---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/422#issuecomment-84020664
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20150320/6ec80aeb/attachment.html>