[mlpack-git] master: Why did I merge that change in? It broke everything. Revert... (e5e7ec3)

gitdub at big.cc.gt.atl.ga.us gitdub at big.cc.gt.atl.ga.us
Thu Mar 5 22:04:58 EST 2015


Repository : https://github.com/mlpack/mlpack

On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/904762495c039e345beba14c1142fd719b3bd50e...f94823c800ad6f7266995c700b1b630d5ffdcf40

>---------------------------------------------------------------

commit e5e7ec35373c3f82c6062e4741788a5a63d2bdac
Author: Ryan Curtin <ryan at ratml.org>
Date:   Thu Dec 11 16:51:38 2014 +0000

    Why did I merge that change in?  It broke everything.  Revert...


>---------------------------------------------------------------

e5e7ec35373c3f82c6062e4741788a5a63d2bdac
 src/mlpack/tests/cosine_tree_test.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mlpack/tests/cosine_tree_test.cpp b/src/mlpack/tests/cosine_tree_test.cpp
index eed5c3e..2f44d7d 100644
--- a/src/mlpack/tests/cosine_tree_test.cpp
+++ b/src/mlpack/tests/cosine_tree_test.cpp
@@ -105,8 +105,8 @@ BOOST_AUTO_TEST_CASE(CosineNodeCosineSplit)
 
       // Check if the columns assigned to the children agree with the splitting
       // condition.
-//      double cosineMax = arma::max(cosines % (cosines < 1));
-//      double cosineMin = arma::min(cosines);
+      double cosineMax = arma::max(cosines % (cosines < 1));
+      double cosineMin = arma::min(cosines);
 
       for (i = 0; i < leftIndices.size(); i++)
         BOOST_CHECK_LT(cosineMax - cosines(i), cosines(i) - cosineMin);



More information about the mlpack-git mailing list