[mlpack-git] master: Don't test on Armadillo 4.300.0 through 4.400.x because there is a bug in Mat::load(istream&) which prevents loading from type hdf5_binary. (The bug is simply the omission of the hdf5_binary case from the switch() statement actually.) (04d4d3d)

gitdub at big.cc.gt.atl.ga.us gitdub at big.cc.gt.atl.ga.us
Thu Mar 5 22:03:31 EST 2015


Repository : https://github.com/mlpack/mlpack

On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/904762495c039e345beba14c1142fd719b3bd50e...f94823c800ad6f7266995c700b1b630d5ffdcf40

>---------------------------------------------------------------

commit 04d4d3d054472d4df87c658afa0d88421d7c8141
Author: Ryan Curtin <ryan at ratml.org>
Date:   Tue Nov 18 22:55:23 2014 +0000

    Don't test on Armadillo 4.300.0 through 4.400.x because there is a bug in
    Mat::load(istream&) which prevents loading from type hdf5_binary.  (The bug is
    simply the omission of the hdf5_binary case from the switch() statement
    actually.)


>---------------------------------------------------------------

04d4d3d054472d4df87c658afa0d88421d7c8141
 src/mlpack/tests/load_save_test.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/mlpack/tests/load_save_test.cpp b/src/mlpack/tests/load_save_test.cpp
index d1c6ff1..d889dea 100644
--- a/src/mlpack/tests/load_save_test.cpp
+++ b/src/mlpack/tests/load_save_test.cpp
@@ -378,7 +378,9 @@ BOOST_AUTO_TEST_CASE(SavePGMBinaryTest)
   remove("test_file.pgm");
 }
 
-#ifdef ARMA_USE_HDF5
+#if defined(ARMA_USE_HDF5) && (ARMA_VERSION_MAJOR == 3 \
+    || (ARMA_VERSION_MAJOR == 4 && (ARMA_VERSION_MINOR < 300 \
+    ||  ARMA_VERSION_MINOR > 400)))
 /**
  * Make sure load as HDF5 is successful.
  */



More information about the mlpack-git mailing list