[mlpack-git] master: When Conrad took the patch, he stripped out a lot of compatibility between iterators, so... take the tests depending on that functionality out. (10d89ab)

gitdub at big.cc.gt.atl.ga.us gitdub at big.cc.gt.atl.ga.us
Thu Mar 5 21:57:44 EST 2015


Repository : https://github.com/mlpack/mlpack

On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/904762495c039e345beba14c1142fd719b3bd50e...f94823c800ad6f7266995c700b1b630d5ffdcf40

>---------------------------------------------------------------

commit 10d89ab7c83dcc9a05c9c0851a41e1fde51dbc30
Author: Ryan Curtin <ryan at ratml.org>
Date:   Thu Aug 14 16:23:25 2014 +0000

    When Conrad took the patch, he stripped out a lot of compatibility between
    iterators, so... take the tests depending on that functionality out.


>---------------------------------------------------------------

10d89ab7c83dcc9a05c9c0851a41e1fde51dbc30
 src/mlpack/tests/arma_extend_test.cpp | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/src/mlpack/tests/arma_extend_test.cpp b/src/mlpack/tests/arma_extend_test.cpp
index 67c8cd9..6bc7dff 100644
--- a/src/mlpack/tests/arma_extend_test.cpp
+++ b/src/mlpack/tests/arma_extend_test.cpp
@@ -35,8 +35,6 @@ BOOST_AUTO_TEST_CASE(InplaceReshapeColumnTest)
  * Make sure we can reshape a large matrix.
  */
 BOOST_AUTO_TEST_CASE(InplaceReshapeMatrixTest)
-{
-  arma::mat X;
   X.randu(8, 10);
   arma::mat oldX = X;
 
@@ -92,8 +90,6 @@ BOOST_AUTO_TEST_CASE(ConstRowColIteratorTest)
   } while (it != X.begin_row_col());
 
   BOOST_REQUIRE_EQUAL(count, 0);
-  // make sure it can be constructed from row_iterator
-  it = X.begin_row(0);
 }
 
 /**
@@ -140,9 +136,6 @@ BOOST_AUTO_TEST_CASE(RowColIteratorTest)
   } while (it != X.begin_row_col());
 
   BOOST_REQUIRE_EQUAL(count, 0);
-
-  // Make sure it can be constructed from row_iterator.
-  it = X.begin_row(0);
 }
 
 /**
@@ -155,14 +148,14 @@ BOOST_AUTO_TEST_CASE(MatRowColIteratorDecrementOperatorTest)
   mat::row_col_iterator it1 = test.begin_row_col();
   mat::row_col_iterator it2 = it1;
 
-  // check that postfix-- does not decrement the position when position is pointing
-  // to the begining
+  // check that postfix-- does not decrement the position when position is
+  // pointing to the begining
   it2--;
   BOOST_REQUIRE_EQUAL(it1.row(), it2.row());
   BOOST_REQUIRE_EQUAL(it1.col(), it2.col());
 
-  // check that prefix-- does not decrement the position when position is pointing
-  // to the begining
+  // check that prefix-- does not decrement the position when position is
+  // pointing to the begining
   --it2;
   BOOST_REQUIRE_EQUAL(it1.row(), it2.row());
   BOOST_REQUIRE_EQUAL(it1.col(), it2.col());



More information about the mlpack-git mailing list