[mlpack-git] master, mlpack-1.0.x: Don't use arma::unique() because it's slow. (a69331b)

gitdub at big.cc.gt.atl.ga.us gitdub at big.cc.gt.atl.ga.us
Thu Mar 5 21:52:30 EST 2015


Repository : https://github.com/mlpack/mlpack

On branches: master,mlpack-1.0.x
Link       : https://github.com/mlpack/mlpack/compare/904762495c039e345beba14c1142fd719b3bd50e...f94823c800ad6f7266995c700b1b630d5ffdcf40

>---------------------------------------------------------------

commit a69331b628a833b349d77d0ba35ae96e3a0cf8b7
Author: Ryan Curtin <ryan at ratml.org>
Date:   Wed Jul 9 19:55:15 2014 +0000

    Don't use arma::unique() because it's slow.


>---------------------------------------------------------------

a69331b628a833b349d77d0ba35ae96e3a0cf8b7
 src/mlpack/methods/perceptron/perceptron_impl.hpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/mlpack/methods/perceptron/perceptron_impl.hpp b/src/mlpack/methods/perceptron/perceptron_impl.hpp
index 08b03c6..531b143 100644
--- a/src/mlpack/methods/perceptron/perceptron_impl.hpp
+++ b/src/mlpack/methods/perceptron/perceptron_impl.hpp
@@ -33,10 +33,8 @@ Perceptron<LearnPolicy, WeightInitializationPolicy, MatType>::Perceptron(
     const arma::Row<size_t>& labels,
     int iterations)
 {
-  arma::Row<size_t> uniqueLabels = arma::unique(labels);
-
   WeightInitializationPolicy WIP;
-  WIP.Initialize(weightVectors, uniqueLabels.n_elem, data.n_rows + 1);
+  WIP.Initialize(weightVectors, arma::max(labels) + 1, data.n_rows + 1);
 
   // Start training.
   classLabels = labels;



More information about the mlpack-git mailing list