[mlpack-git] master, mlpack-1.0.x: clang complains when default parameters aren't part of the original declaration. Also vim removes trailing whitespaces, so this diff looks way longer and more complex than it actually is... (21f2bb9)

gitdub at big.cc.gt.atl.ga.us gitdub at big.cc.gt.atl.ga.us
Thu Mar 5 21:52:06 EST 2015


Repository : https://github.com/mlpack/mlpack

On branches: master,mlpack-1.0.x
Link       : https://github.com/mlpack/mlpack/compare/904762495c039e345beba14c1142fd719b3bd50e...f94823c800ad6f7266995c700b1b630d5ffdcf40

>---------------------------------------------------------------

commit 21f2bb94676a45034e8991ad36c831dd269dbba9
Author: Ryan Curtin <ryan at ratml.org>
Date:   Tue Jul 8 17:42:46 2014 +0000

    clang complains when default parameters aren't part of the original declaration.
    Also vim removes trailing whitespaces, so this diff looks way longer and more
    complex than it actually is...


>---------------------------------------------------------------

21f2bb94676a45034e8991ad36c831dd269dbba9
 src/mlpack/core/tree/rectangle_tree/rectangle_tree.hpp      | 10 +++++-----
 src/mlpack/core/tree/rectangle_tree/rectangle_tree_impl.hpp | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/mlpack/core/tree/rectangle_tree/rectangle_tree.hpp b/src/mlpack/core/tree/rectangle_tree/rectangle_tree.hpp
index e50d372..550cf74 100644
--- a/src/mlpack/core/tree/rectangle_tree/rectangle_tree.hpp
+++ b/src/mlpack/core/tree/rectangle_tree/rectangle_tree.hpp
@@ -100,11 +100,11 @@ class RectangleTree
    * "CENTERAL" DATA MATRIX.
    */
   RectangleTree(MatType& data,
-		const size_t maxLeafSize,
-		const size_t minLeafSize,
-		const size_t maxNumChildren,
-		const size_t minNumChildren,
-		const size_t firstDataIndex
+		const size_t maxLeafSize = 20,
+		const size_t minLeafSize = 6,
+		const size_t maxNumChildren = 4,
+		const size_t minNumChildren = 0,
+		const size_t firstDataIndex = 0
  	      );
 
   /**
diff --git a/src/mlpack/core/tree/rectangle_tree/rectangle_tree_impl.hpp b/src/mlpack/core/tree/rectangle_tree/rectangle_tree_impl.hpp
index d1ed3e2..ad6f038 100644
--- a/src/mlpack/core/tree/rectangle_tree/rectangle_tree_impl.hpp
+++ b/src/mlpack/core/tree/rectangle_tree/rectangle_tree_impl.hpp
@@ -23,11 +23,11 @@ template<typename SplitType,
          typename MatType>
 RectangleTree<SplitType, DescentType, StatisticType, MatType>::RectangleTree(
     MatType& data,
-    const size_t maxLeafSize = 20,
-    const size_t minLeafSize = 6,
-    const size_t maxNumChildren = 4,
-    const size_t minNumChildren = 0,
-    const size_t firstDataIndex = 0):
+    const size_t maxLeafSize,
+    const size_t minLeafSize,
+    const size_t maxNumChildren,
+    const size_t minNumChildren,
+    const size_t firstDataIndex):
     maxNumChildren(maxNumChildren),
     minNumChildren(minNumChildren),
     numChildren(0),



More information about the mlpack-git mailing list