[mlpack-git] master, mlpack-1.0.x: Don't include <armadillo> before <mlpack/core.hpp>. (43dbca8)

gitdub at big.cc.gt.atl.ga.us gitdub at big.cc.gt.atl.ga.us
Thu Mar 5 21:51:58 EST 2015


Repository : https://github.com/mlpack/mlpack

On branches: master,mlpack-1.0.x
Link       : https://github.com/mlpack/mlpack/compare/904762495c039e345beba14c1142fd719b3bd50e...f94823c800ad6f7266995c700b1b630d5ffdcf40

>---------------------------------------------------------------

commit 43dbca89eb633458c8718b797823561d75b2188d
Author: Ryan Curtin <ryan at ratml.org>
Date:   Tue Jul 8 12:10:48 2014 +0000

    Don't include <armadillo> before <mlpack/core.hpp>.


>---------------------------------------------------------------

43dbca89eb633458c8718b797823561d75b2188d
 src/mlpack/tests/lars_test.cpp                    | 6 ++----
 src/mlpack/tests/local_coordinate_coding_test.cpp | 4 ++--
 src/mlpack/tests/radical_test.cpp                 | 3 +--
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/mlpack/tests/lars_test.cpp b/src/mlpack/tests/lars_test.cpp
index 416835c..936ca7d 100644
--- a/src/mlpack/tests/lars_test.cpp
+++ b/src/mlpack/tests/lars_test.cpp
@@ -1,14 +1,12 @@
 /**
  * @file lars_test.cpp
+ * @author Nishant Mehta
  *
- * Test for LARS
+ * Test for LARS.
  */
 
 // Note: We don't use BOOST_REQUIRE_CLOSE in the code below because we need
 // to use FPC_WEAK, and it's not at all intuitive how to do that.
-
-
-#include <armadillo>
 #include <mlpack/methods/lars/lars.hpp>
 
 #include <boost/test/unit_test.hpp>
diff --git a/src/mlpack/tests/local_coordinate_coding_test.cpp b/src/mlpack/tests/local_coordinate_coding_test.cpp
index 96b39d0..cfbe114 100644
--- a/src/mlpack/tests/local_coordinate_coding_test.cpp
+++ b/src/mlpack/tests/local_coordinate_coding_test.cpp
@@ -1,12 +1,12 @@
 /**
  * @file local_coordinate_coding_test.cpp
+ * @author Nishant Mehta
  *
- * Test for Local Coordinate Coding
+ * Test for Local Coordinate Coding.
  */
 
 // Note: We don't use BOOST_REQUIRE_CLOSE in the code below because we need
 // to use FPC_WEAK, and it's not at all intuitive how to do that.
-#include <armadillo>
 #include <mlpack/methods/local_coordinate_coding/lcc.hpp>
 
 #include <boost/test/unit_test.hpp>
diff --git a/src/mlpack/tests/radical_test.cpp b/src/mlpack/tests/radical_test.cpp
index 33bd584..3808309 100644
--- a/src/mlpack/tests/radical_test.cpp
+++ b/src/mlpack/tests/radical_test.cpp
@@ -2,9 +2,8 @@
  * @file radical_main.cpp
  * @author Nishant Mehta
  *
- * Executable for RADICAL
+ * Test for RADICAL.
  */
-#include <armadillo>
 #include <mlpack/core.hpp>
 #include <mlpack/methods/radical/radical.hpp>
 #include <boost/test/unit_test.hpp>



More information about the mlpack-git mailing list