[mlpack-git] master: move matrix_completion_impl.hpp to matrix_completion.cpp (905bd4f)

[gitdub at big.cc.gt.atl.ga.us]

Repository : https://github.com/mlpack/mlpack

On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/1ba8341ea46ff52edb4a5c41466c1d03d1fce61f...184c36dda87a9259c74d82265c2027896e097d42

>---------------------------------------------------------------

commit 905bd4fd2155847263692b008c4091050ddd1bf3
Author: Stephen Tu <tu.stephenl at gmail.com>
Date:   Tue Jan 13 10:59:02 2015 -0800

    move matrix_completion_impl.hpp to matrix_completion.cpp
    
    avoid a possible multiple definitions issue at link time


>---------------------------------------------------------------

905bd4fd2155847263692b008c4091050ddd1bf3
 src/mlpack/methods/matrix_completion/CMakeLists.txt                 | 2 +-
 .../{matrix_completion_impl.hpp => matrix_completion.cpp}           | 6 ++----
 src/mlpack/methods/matrix_completion/matrix_completion.hpp          | 3 ---
 3 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/mlpack/methods/matrix_completion/CMakeLists.txt b/src/mlpack/methods/matrix_completion/CMakeLists.txt
index 282021f..9c71524 100644
--- a/src/mlpack/methods/matrix_completion/CMakeLists.txt
+++ b/src/mlpack/methods/matrix_completion/CMakeLists.txt
@@ -2,7 +2,7 @@
 # Anything not in this list will not be compiled into MLPACK.
 set(SOURCES
   matrix_completion.hpp
-  matrix_completion_impl.hpp
+  matrix_completion.cpp
 )
 
 # Add directory name to sources.
diff --git a/src/mlpack/methods/matrix_completion/matrix_completion_impl.hpp b/src/mlpack/methods/matrix_completion/matrix_completion.cpp
similarity index 95%
rename from src/mlpack/methods/matrix_completion/matrix_completion_impl.hpp
rename to src/mlpack/methods/matrix_completion/matrix_completion.cpp
index 89dc737..15224b5 100644
--- a/src/mlpack/methods/matrix_completion/matrix_completion_impl.hpp
+++ b/src/mlpack/methods/matrix_completion/matrix_completion.cpp
@@ -4,8 +4,8 @@
  *
  * Implementation of MatrixCompletion class.
  */
-#ifndef __MLPACK_METHODS_MATRIX_COMPLETION_MATRIX_COMPLETION_IMPL_HPP
-#define __MLPACK_METHODS_MATRIX_COMPLETION_MATRIX_COMPLETION_IMPL_HPP
+
+#include "matrix_completion.hpp"
 
 namespace mlpack {
 namespace matrix_completion {
@@ -107,5 +107,3 @@ size_t MatrixCompletion::DefaultRank(const size_t m,
 
 } // namespace matrix_completion
 } // namespace mlpack
-
-#endif
diff --git a/src/mlpack/methods/matrix_completion/matrix_completion.hpp b/src/mlpack/methods/matrix_completion/matrix_completion.hpp
index 0f6c5bb..718f46c 100644
--- a/src/mlpack/methods/matrix_completion/matrix_completion.hpp
+++ b/src/mlpack/methods/matrix_completion/matrix_completion.hpp
@@ -136,7 +136,4 @@ class MatrixCompletion
 } // namespace matrix_completion
 } // namespace mlpack
 
-// Include implementation.
-#include "matrix_completion_impl.hpp"
-
 #endif