[mlpack-git] master: Loosen bound since it is probabilistic and we have many tests. (5919cc0)

gitdub at big.cc.gt.atl.ga.us gitdub at big.cc.gt.atl.ga.us
Wed Dec 23 12:57:30 EST 2015


Repository : https://github.com/mlpack/mlpack

On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/a263be41587a5769ba4ac3d47b801555f7692731...0c3faf26aab23f6450a51a64932a6ba511d981e7

>---------------------------------------------------------------

commit 5919cc0c476c2d46b2021fdf6f5cc3867feb91e5
Author: ryan <ryan at ratml.org>
Date:   Wed Dec 23 12:43:00 2015 -0500

    Loosen bound since it is probabilistic and we have many tests.


>---------------------------------------------------------------

5919cc0c476c2d46b2021fdf6f5cc3867feb91e5
 src/mlpack/tests/allkrann_search_test.cpp | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/mlpack/tests/allkrann_search_test.cpp b/src/mlpack/tests/allkrann_search_test.cpp
index b3c36ea..0ea62b6 100644
--- a/src/mlpack/tests/allkrann_search_test.cpp
+++ b/src/mlpack/tests/allkrann_search_test.cpp
@@ -616,7 +616,7 @@ BOOST_AUTO_TEST_CASE(MoveTrainTest)
  */
 BOOST_AUTO_TEST_CASE(RAModelTest)
 {
-  // Ensure that we can build an NSModel<NearestNeighborSearch> and get correct
+  // Ensure that we can build an RAModel<NearestNeighborSearch> and get correct
   // results.
   typedef RAModel<NearestNeighborSort> KNNModel;
 
@@ -626,19 +626,19 @@ BOOST_AUTO_TEST_CASE(RAModelTest)
 
   // Build all the possible models.
   KNNModel models[8];
-  models[0] = KNNModel(KNNModel::TreeTypes::KD_TREE, true);
-  models[1] = KNNModel(KNNModel::TreeTypes::KD_TREE, false);
-  models[2] = KNNModel(KNNModel::TreeTypes::COVER_TREE, true);
-  models[3] = KNNModel(KNNModel::TreeTypes::COVER_TREE, false);
-  models[4] = KNNModel(KNNModel::TreeTypes::R_TREE, true);
-  models[5] = KNNModel(KNNModel::TreeTypes::R_TREE, false);
-  models[6] = KNNModel(KNNModel::TreeTypes::R_STAR_TREE, true);
-  models[7] = KNNModel(KNNModel::TreeTypes::R_STAR_TREE, false);
+  models[0] = KNNModel(KNNModel::TreeTypes::KD_TREE, false);
+  models[1] = KNNModel(KNNModel::TreeTypes::KD_TREE, true);
+  models[2] = KNNModel(KNNModel::TreeTypes::COVER_TREE, false);
+  models[3] = KNNModel(KNNModel::TreeTypes::COVER_TREE, true);
+  models[4] = KNNModel(KNNModel::TreeTypes::R_TREE, false);
+  models[5] = KNNModel(KNNModel::TreeTypes::R_TREE, true);
+  models[6] = KNNModel(KNNModel::TreeTypes::R_STAR_TREE, false);
+  models[7] = KNNModel(KNNModel::TreeTypes::R_STAR_TREE, true);
 
   arma::Mat<size_t> qrRanks;
   data::Load("rann_test_qr_ranks.csv", qrRanks, true, false); // No transpose.
 
-  for (size_t j = 0; j < 2; ++j)
+  for (size_t j = 0; j < 3; ++j)
   {
     for (size_t i = 0; i < 8; ++i)
     {
@@ -691,7 +691,7 @@ BOOST_AUTO_TEST_CASE(RAModelTest)
 
       // assert that at most 5% of the queries fall out of this threshold
       // 5% of 100 queries is 5.
-      size_t maxNumQueriesFail = 6;
+      size_t maxNumQueriesFail = 12; // Looser bound due to multiple trials.
 
       BOOST_REQUIRE_LT(numQueriesFail, maxNumQueriesFail);
     }



More information about the mlpack-git mailing list