[mlpack-git] master: Fix serialization bug. (3122b83)

gitdub at big.cc.gt.atl.ga.us gitdub at big.cc.gt.atl.ga.us
Wed Dec 23 11:43:19 EST 2015


Repository : https://github.com/mlpack/mlpack

On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/de9cc4b05069e1fa4793d9355f2f595af5ff45d2...6070527af14296cd99739de6c62666cc5d2a2125

>---------------------------------------------------------------

commit 3122b83a389f2bc33d228be95d327733dd0a8a4a
Author: ryan <ryan at ratml.org>
Date:   Thu Oct 1 14:18:44 2015 -0400

    Fix serialization bug.


>---------------------------------------------------------------

3122b83a389f2bc33d228be95d327733dd0a8a4a
 src/mlpack/methods/hoeffding_trees/hoeffding_numeric_split_impl.hpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/mlpack/methods/hoeffding_trees/hoeffding_numeric_split_impl.hpp b/src/mlpack/methods/hoeffding_trees/hoeffding_numeric_split_impl.hpp
index 0e18cd9..fa156a6 100644
--- a/src/mlpack/methods/hoeffding_trees/hoeffding_numeric_split_impl.hpp
+++ b/src/mlpack/methods/hoeffding_trees/hoeffding_numeric_split_impl.hpp
@@ -86,7 +86,6 @@ template<typename FitnessFunction, typename ObservationType>
 double HoeffdingNumericSplit<FitnessFunction, ObservationType>::
     EvaluateFitnessFunction() const
 {
-  Log::Debug << sufficientStatistics.t();
   if (samplesSeen < observationsBeforeBinning)
     return 0.0;
   else
@@ -151,7 +150,7 @@ void HoeffdingNumericSplit<FitnessFunction, ObservationType>::Serialize(
   ar & CreateNVP(observationsBeforeBinning, "observationsBeforeBinning");
   ar & CreateNVP(bins, "bins");
 
-  if (samplesSeen > observationsBeforeBinning)
+  if (samplesSeen >= observationsBeforeBinning)
   {
     // The binning has happened, so we only need to save the resulting bins.
     ar & CreateNVP(splitPoints, "splitPoints");



More information about the mlpack-git mailing list