[mlpack-git] master: Fix epsilon calculation. (b742e17)
gitdub at big.cc.gt.atl.ga.us
gitdub at big.cc.gt.atl.ga.us
Wed Dec 23 11:42:28 EST 2015
Repository : https://github.com/mlpack/mlpack
On branch : master
Link : https://github.com/mlpack/mlpack/compare/de9cc4b05069e1fa4793d9355f2f595af5ff45d2...6070527af14296cd99739de6c62666cc5d2a2125
>---------------------------------------------------------------
commit b742e17157f9c471e8dd8737d227472b3aca4688
Author: ryan <ryan at ratml.org>
Date: Tue Sep 22 16:14:34 2015 -0400
Fix epsilon calculation.
>---------------------------------------------------------------
b742e17157f9c471e8dd8737d227472b3aca4688
src/mlpack/methods/hoeffding_trees/hoeffding_split_impl.hpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mlpack/methods/hoeffding_trees/hoeffding_split_impl.hpp b/src/mlpack/methods/hoeffding_trees/hoeffding_split_impl.hpp
index 959a628..f294adc 100644
--- a/src/mlpack/methods/hoeffding_trees/hoeffding_split_impl.hpp
+++ b/src/mlpack/methods/hoeffding_trees/hoeffding_split_impl.hpp
@@ -86,7 +86,7 @@ size_t HoeffdingSplit<
// Calculate epsilon, the value we need things to be greater than.
const double rSquared = std::pow(FitnessFunction::Range(numClasses), 2.0);
const double epsilon = std::sqrt(rSquared *
- std::log(1.0 / successProbability) / (2 * numSamples));
+ std::log(1.0 / (1.0 - successProbability)) / (2 * numSamples));
arma::vec gains(categoricalSplits.size() + numericSplits.size());
for (size_t i = 0; i < categoricalSplits.size(); ++i)
More information about the mlpack-git
mailing list