[mlpack-git] master: Fix compilation warnings. (338c9dc)

gitdub at big.cc.gt.atl.ga.us gitdub at big.cc.gt.atl.ga.us
Wed Dec 23 11:42:24 EST 2015


Repository : https://github.com/mlpack/mlpack

On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/de9cc4b05069e1fa4793d9355f2f595af5ff45d2...6070527af14296cd99739de6c62666cc5d2a2125

>---------------------------------------------------------------

commit 338c9dcf20e92edd47f7171a2900d6680ef1a7ae
Author: ryan <ryan at ratml.org>
Date:   Tue Sep 22 16:07:36 2015 -0400

    Fix compilation warnings.


>---------------------------------------------------------------

338c9dcf20e92edd47f7171a2900d6680ef1a7ae
 src/mlpack/methods/hoeffding_trees/hoeffding_split.hpp      | 4 ++--
 src/mlpack/methods/hoeffding_trees/hoeffding_split_impl.hpp | 7 ++-----
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/mlpack/methods/hoeffding_trees/hoeffding_split.hpp b/src/mlpack/methods/hoeffding_trees/hoeffding_split.hpp
index 716e164..5ca5f33 100644
--- a/src/mlpack/methods/hoeffding_trees/hoeffding_split.hpp
+++ b/src/mlpack/methods/hoeffding_trees/hoeffding_split.hpp
@@ -50,9 +50,9 @@ class HoeffdingSplit
   std::vector<NumericSplitType> numericSplits;
   std::vector<CategoricalSplitType> categoricalSplits;
 
-  const data::DatasetInfo& datasetInfo;
-  size_t numClasses;
   size_t numSamples;
+  size_t numClasses;
+  const data::DatasetInfo& datasetInfo;
   double successProbability;
 
   // And we need to keep some information for after we have split.
diff --git a/src/mlpack/methods/hoeffding_trees/hoeffding_split_impl.hpp b/src/mlpack/methods/hoeffding_trees/hoeffding_split_impl.hpp
index 35fb6d6..c8fc1df 100644
--- a/src/mlpack/methods/hoeffding_trees/hoeffding_split_impl.hpp
+++ b/src/mlpack/methods/hoeffding_trees/hoeffding_split_impl.hpp
@@ -25,8 +25,8 @@ HoeffdingSplit<
     numClasses(numClasses),
     datasetInfo(datasetInfo),
     successProbability(successProbability),
-    categoricalSplit(0),
-    splitDimension(size_t(-1))
+    splitDimension(size_t(-1)),
+    categoricalSplit(0)
 {
   for (size_t i = 0; i < dimensionality; ++i)
   {
@@ -96,20 +96,17 @@ size_t HoeffdingSplit<
   double largest = -DBL_MAX;
   size_t largestIndex = 0;
   double secondLargest = -DBL_MAX;
-  size_t secondLargestIndex = 0;
   for (size_t i = 0; i < gains.n_elem; ++i)
   {
     if (gains[i] > largest)
     {
       secondLargest = largest;
-      secondLargestIndex = largestIndex;
       largest = gains[i];
       largestIndex = i;
     }
     else if (gains[i] > secondLargest)
     {
       secondLargest = gains[i];
-      secondLargestIndex = i;
     }
   }
 



More information about the mlpack-git mailing list