[mlpack-svn] r17188 - mlpack/trunk/src/mlpack/core/tree/rectangle_tree

fastlab-svn at coffeetalk-1.cc.gatech.edu fastlab-svn at coffeetalk-1.cc.gatech.edu
Wed Sep 24 15:46:32 EDT 2014


Author: rcurtin
Date: Wed Sep 24 15:46:31 2014
New Revision: 17188

Log:
Move MAX_OVERLAP to be a member in the mlpack::tree namespace to fix errors on
Visual Studio.  Thanks to SinisterMJ for pointing this out.  #369.


Modified:
   mlpack/trunk/src/mlpack/core/tree/rectangle_tree/x_tree_split.hpp

Modified: mlpack/trunk/src/mlpack/core/tree/rectangle_tree/x_tree_split.hpp
==============================================================================
--- mlpack/trunk/src/mlpack/core/tree/rectangle_tree/x_tree_split.hpp	(original)
+++ mlpack/trunk/src/mlpack/core/tree/rectangle_tree/x_tree_split.hpp	Wed Sep 24 15:46:31 2014
@@ -16,6 +16,14 @@
 namespace tree /** Trees and tree-building procedures. */ {
 
 /**
+ * The X-tree paper says that a maximum allowable overlap of 20% works well.
+ *
+ * This code should eventually be refactored so as to avoid polluting
+ * mlpack::tree with this random double.
+ */
+const double MAX_OVERLAP = 0.2;
+
+/**
  * A Rectangle Tree has new points inserted at the bottom.  When these
  * nodes overflow, we split them, moving up the tree and splitting nodes
  * as necessary.
@@ -28,11 +36,6 @@
 public:
 
 /**
- * The X-tree paper says that a maximum allowable overlap of 20% works well.
- */
-const static double MAX_OVERLAP = 0.2;
-
-/**
  * Split a leaf node using the algorithm described in "The R*-tree: An Efficient and Robust Access method
  * for Points and Rectangles."  If necessary, this split will propagate
  * upwards through the tree.



More information about the mlpack-svn mailing list