[mlpack-svn] r17186 - mlpack/trunk/src/mlpack/core/tree/rectangle_tree
fastlab-svn at coffeetalk-1.cc.gatech.edu
fastlab-svn at coffeetalk-1.cc.gatech.edu
Tue Sep 16 17:04:34 EDT 2014
Author: rcurtin
Date: Tue Sep 16 17:04:26 2014
New Revision: 17186
Log:
Add comment pointing out that there is a bug.
Modified:
mlpack/trunk/src/mlpack/core/tree/rectangle_tree/x_tree_split.hpp
Modified: mlpack/trunk/src/mlpack/core/tree/rectangle_tree/x_tree_split.hpp
==============================================================================
--- mlpack/trunk/src/mlpack/core/tree/rectangle_tree/x_tree_split.hpp (original)
+++ mlpack/trunk/src/mlpack/core/tree/rectangle_tree/x_tree_split.hpp Tue Sep 16 17:04:26 2014
@@ -2,8 +2,10 @@
* @file x_tre_split.hpp
* @author Andrew Wells
*
- * Defintion of the XTreeSplit class, a class that splits the nodes of an X tree, starting
- * at a leaf node and moving upwards if necessary.
+ * Defintion of the XTreeSplit class, a class that splits the nodes of an X
+ * tree, starting at a leaf node and moving upwards if necessary.
+ *
+ * This is known to have a bug: see #368.
*/
#ifndef __MLPACK_CORE_TREE_RECTANGLE_TREE_X_TREE_SPLIT_HPP
#define __MLPACK_CORE_TREE_RECTANGLE_TREE_X_TREE_SPLIT_HPP
@@ -25,11 +27,11 @@
{
public:
-/**
+/**
* The X-tree paper says that a maximum allowable overlap of 20% works well.
*/
const static double MAX_OVERLAP = 0.2;
-
+
/**
* Split a leaf node using the algorithm described in "The R*-tree: An Efficient and Robust Access method
* for Points and Rectangles." If necessary, this split will propagate
@@ -38,7 +40,7 @@
static void SplitLeafNode(RectangleTree<XTreeSplit<DescentType, StatisticType, MatType>, DescentType, StatisticType, MatType>* tree, std::vector<bool>& relevels);
/**
- * Split a non-leaf node using the "default" algorithm. If this is a root node, the
+ * Split a non-leaf node using the "default" algorithm. If this is a root node, the
* tree increases in depth.
*/
static bool SplitNonLeafNode(RectangleTree<XTreeSplit<DescentType, StatisticType, MatType>, DescentType, StatisticType, MatType>* tree, std::vector<bool>& relevels);
@@ -75,4 +77,4 @@
// Include implementation
#include "x_tree_split_impl.hpp"
-#endif
\ No newline at end of file
+#endif
More information about the mlpack-svn
mailing list