[mlpack-svn] [MLPACK] #320: BinarySpaceTree<BallBound<> > fails
MLPACK Trac
trac at coffeetalk-1.cc.gatech.edu
Thu Feb 20 22:33:05 EST 2014
#320: BinarySpaceTree<BallBound<> > fails
-----------------------------------------------------+----------------------
Reporter: rcurtin | Owner:
Type: defect | Status: new
Priority: major | Milestone: mlpack 1.0.9
Component: mlpack | Resolution:
Keywords: ballbound, metric, instantiated metric | Blocking: 246, 274
Blocked By: |
-----------------------------------------------------+----------------------
Comment (by rcurtin):
Hi,
Thank you for the patch, but it needs a little bit of work. A ball should
work with any metric, not just the LMetric; after all, a ball with center
```c``` and radius ```r``` is defined as the set of points
{{{
{ p : d(p, c) ≤ r }
}}}
for any metric ```d()```. So instead of having Power and TakeRoot as a
template parameter, the MetricType itself should be a template parameter,
and all distance calculations done by the BallBound should be done by an
instantiated MetricType. If you can make these modifications then we can
start to integrate the patch.
Thanks,
Ryan
--
Ticket URL: <http://trac.research.cc.gatech.edu/fastlab/ticket/320#comment:1>
MLPACK <www.fast-lab.org>
MLPACK is an intuitive, fast, and scalable C++ machine learning library developed at Georgia Tech.
More information about the mlpack-svn
mailing list