[mlpack-svn] r17069 - mlpack/trunk/src/mlpack/core/tree/rectangle_tree

[fastlab-svn at coffeetalk-1.cc.gatech.edu]

Author: rcurtin
Date: Mon Aug 18 21:00:30 2014
New Revision: 17069

Log:
arma::prod is faster, in this case.


Modified:
   mlpack/trunk/src/mlpack/core/tree/rectangle_tree/r_tree_split_impl.hpp

Modified: mlpack/trunk/src/mlpack/core/tree/rectangle_tree/r_tree_split_impl.hpp
==============================================================================
--- mlpack/trunk/src/mlpack/core/tree/rectangle_tree/r_tree_split_impl.hpp	(original)
+++ mlpack/trunk/src/mlpack/core/tree/rectangle_tree/r_tree_split_impl.hpp	Mon Aug 18 21:00:30 2014
@@ -182,14 +182,8 @@
   {
     for (int j = i + 1; j < tree.Count(); j++)
     {
-      double score = 1.0;
-      for (int k = 0; k < tree.Bound().Dim(); k++)
-      {
-        // Points (in the dataset) are stored by column, but this function takes
-        // (row, col).
-        score *= std::abs(tree.LocalDataset().at(k, i) -
-            tree.LocalDataset().at(k, j));
-      }
+      const double score = arma::prod(arma::abs(tree.LocalDataset().col(i) -
+          tree.LocalDataset().col(j)));
 
       if (score > worstPairScore)
       {