[mlpack-svn] r15873 - mlpack/trunk/src/mlpack/methods/cf

fastlab-svn at coffeetalk-1.cc.gatech.edu fastlab-svn at coffeetalk-1.cc.gatech.edu
Mon Sep 30 15:38:53 EDT 2013


Author: rcurtin
Date: Mon Sep 30 15:38:53 2013
New Revision: 15873

Log:
Clean up Decompose().


Modified:
   mlpack/trunk/src/mlpack/methods/cf/cf.cpp

Modified: mlpack/trunk/src/mlpack/methods/cf/cf.cpp
==============================================================================
--- mlpack/trunk/src/mlpack/methods/cf/cf.cpp	(original)
+++ mlpack/trunk/src/mlpack/methods/cf/cf.cpp	Mon Sep 30 15:38:53 2013
@@ -159,15 +159,14 @@
 
 void CF::Decompose()
 {
-   Log::Info<<"Decompose"<<endl;
-   size_t rank = 2;
-  //Presenltly only ALS is supported as an Optimizer
-  //Should be converted to a template
+  // Should this rank be parameterizable?
+  size_t rank = 2;
+
+  // Presently only ALS (via NMF) is supported as an optimizer.  This should be
+  // converted to a template when more optimizers are available.
   NMF<RandomInitialization, WAlternatingLeastSquaresRule,
       HAlternatingLeastSquaresRule> als(10000, 1e-5);
-  als.Apply(cleanedData,rank,w,h);
-  //data::Save("w.csv",w);
-  //data::Save("h.csv",h);
+  als.Apply(cleanedData, rank, w, h);
 }
 
 void CF::GenerateRating()



More information about the mlpack-svn mailing list