[mlpack-svn] [MLPACK] #261: Comment in nca_softmax_error_function_impl.hpp line 236 is wrong

[MLPACK Trac]

#261: Comment in nca_softmax_error_function_impl.hpp line 236 is wrong
----------------------+-----------------------------------------------------
  Reporter:  florian  |        Owner:        
      Type:  defect   |       Status:  closed
  Priority:  minor    |    Milestone:        
 Component:  mlpack   |   Resolution:  fixed 
  Keywords:           |     Blocking:        
Blocked By:           |  
----------------------+-----------------------------------------------------
Changes (by rcurtin):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 Hello Florian,

 Thanks for pointing this out.  It's very important to have correct
 comments in code like this...

 When I wrote this, I think the actual intention of the statement was to
 point out that K(i, j) = K(j, i) so that our evaluation of K(j, i) can be
 added to the denominators of both p_i and p_j.  r13965 fixes the comment
 for correctness.  If you find any other clarifications that are required
 in the comments, let me know.

-- 
Ticket URL: <http://trac.research.cc.gatech.edu/fastlab/ticket/261#comment:1>
MLPACK <www.fast-lab.org>
MLPACK is an intuitive, fast, and scalable C++ machine learning library developed by the FASTLAB at Georgia Tech under Dr. Alex Gray.