[mlpack-svn] [MLPACK] #126: Implement simple PCA

MLPACK Trac trac at coffeetalk-1.cc.gatech.edu
Thu Nov 10 10:04:00 EST 2011

#126: Implement simple PCA
  Reporter:  rcurtin                           |        Owner:  ajinkya   
      Type:  wishlist                          |       Status:  assigned  
  Priority:  major                             |    Milestone:  MLPACK 1.0
 Component:  MLPACK                            |   Resolution:            
  Keywords:  pca kernel_pca covariance method  |     Blocking:  47        
Blocked By:                                    |  

Comment (by rcurtin):

 Before we get to that, can you reformat the code so it follows the
 NewStyleGuidelines?  The tabbing seems very weird on the files you
 submitted.  Additionally, there are no comments documenting the class (see
 neighbor_search for a decent example) and the code isn't const-correct,
 i.e. it is currently

 void Apply(arma::mat& coeff, arma::mat& score, arma::mat& data)

 when it should really be (const arguments first)

 void Apply(const arma::mat& data, arma::mat& coeff, arma::mat& score)

 I have some comments about the API too but fix the spacing/tabbing,
 comments, and const-correctness and we can get to that next.


Ticket URL: <https://trac.research.cc.gatech.edu/fastlab/ticket/126#comment:5>
MLPACK <www.fast-lab.org>
MLPACK is an intuitive, fast, and scalable C++ machine learning library developed by the FASTLAB at Georgia Tech under Dr. Alex Gray.

More information about the mlpack-svn mailing list